adapt to eip-1193 provider changes #317

cryptodev-2s · 2024-07-16T20:32:53Z

After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of @metamask/eth-json-rpc-provider is released, we should adapt to the changes:

We should bump @metamask/eth-json-rpc-provider to rely on the new changes.
At that point, calling sendAsync will be deprecated; we should use request instead.
- There are two middleware which use sendAsync: retryOnEmpty and block-ref.
- We also use sendAsync in providerAsMiddleware.
- Finally, there are a lot of tests that mock sendAsync on the provider. The tests use a helper, stubProviderRequests which does this in particular. These references need to be changed.

Fixes #299

socket-security · 2024-07-16T20:57:52Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	63.6 kB	mcmire
npm/@metamask/[email protected]	None	`0`	86.7 kB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

yarn.lock

legobeat

Hm, unit tests still failing?
https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9975509645/job/27565450801?pr=317

src/block-ref.ts

src/providerAsMiddleware.ts

src/retryOnEmpty.ts

socket-security · 2024-07-18T13:58:20Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

mcmire

The overall approach here makes sense to me. Most of my comments below are minor.

src/block-ref.ts

src/retryOnEmpty.test.ts

src/retryOnEmpty.ts

src/providerAsMiddleware.ts

src/retryOnEmpty.ts

test/util/helpers.ts

src/retryOnEmpty.test.ts

src/block-ref.test.ts

mcmire · 2024-07-19T21:59:02Z

@SocketSecurity ignore npm/@metamask/[email protected]

This is our own package.

mcmire

Had some suggestions, but overall, the approach makes sense.

src/providerAsMiddleware.ts

src/block-ref.ts

src/retryOnEmpty.ts

cryptodev-2s · 2024-07-22T19:41:55Z

@SocketSecurity ignore npm/@metamask/[email protected]

This is our own package.

mcmire

Looks good!

adapt to eip-1193 provider changes

e6fa308

cryptodev-2s added the team-wallet-framework label Jul 16, 2024

cryptodev-2s requested a review from a team as a code owner July 16, 2024 20:32

fix: remove unused import

f690ae3